PR #12834 — the Prospects loading table is the page's own table
Board row p11-x-skeleton-everywhere. PR #12834.
| What | Loading, before | Loading, after | Loaded page | Verdict |
|---|---|---|---|---|
| Columns | 5: Prospect, Property, Stage, Source, Date | 7: Prospect, Property, Stage, Source, Clara, Created, Last Activity | 7: Prospect, Property, Stage, Source, Clara, Created, Last Activity | ✓ matches |
| Rows on first page | 8 rows | 50 rows | 50 rows | ✓ matches |
| Row line colour | rgb(15, 32, 96) | rgb(232, 232, 235) | rgb(232, 232, 235) | ✓ matches |
| Row height | 45px | 34.5px | 39.5px | differs — loaded cell taller than one line (see note) |
| Table top (y) | 344px | 350px | 350px | ✓ matches |
Screenshots, notes, and how they were captured
Before = a79995515f, where the Prospects shell and the shared table are byte-identical to the commit just before #12834 merged (fb0a9bb9b5^). After = current origin/main, which carries #12834 plus the later row-height fix (#12886), so the 45px → 34.5px row height is the two PRs together. The 5px residual against the loaded 39.5px rows is a loaded cell taller than one line of text; neither PR claims it.
How these were captured. Local dev servers bound to the
propflow-stage table (anonymized by construction), signed in as the smoke login, desktop 1440×900. The loading screen is held on screen by an uncommitted local hook (a cookie-gated wait in the list's page.tsx) that is in no PR. Values are read from the rendered DOM. Before = the code before this PR; after = with it.